refactor(ssh): use auth handlers to start SSH connection #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
fix/ssh_auth_on_handler
branch
5 times, most recently
from
16e9429
to
50a9951
Compare
henrybarreto
added
status/needs-review
and removed
do-not-merge
status/work-in-progress
labels
The SSH's ShellHub server is the gateway between the user and its device. Each device added to ShellHub, connects to the gateway, allowing ShellHub's SSH server to be it manager. When a client wants to connect to them device, this request comes first into our SSH server and, after ward, to the device itself. As our server is also an SSH server, what makes the SSH client understands that the user first connects to a server and is redirected to another one, causing problems with some SSH clients' authentication detection. In order to solve it, we, now, connect to the device before starting the session itself, what makes this redirect seamless to the SSH clients. Refs to #3240
henrybarreto
force-pushed
the
fix/ssh_auth_on_handler
branch
from
50a9951
to
90f5b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSH's ShellHub server is the gateway between the user and its device. Each device added to ShellHub, connects to the gateway, allowing ShellHub's SSH server to be it manager. When a client wants to connect to them device, this request comes first into our SSH server and, after ward, to the device itself.
As our server is also an SSH server, what makes the SSH client understands that the user first connects to a server and is redirected to another one, causing problems with some SSH clients' authentication detection.
In order to solve it, we, now, connect to the device before starting the session itself, what makes this redirect seamless to the SSH clients.
Refs to #3240