fix slow query in NamespaceGet #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
fix/namespaceGet-slow-query
branch
from
6692872
to
8d28c37
Compare
Currently, `NamespaceGet` method calculates the total number of devices in a namespace, which may result in a slow query. Since this method is utilized in numerous contexts where the `Namespace.DevicesCount` attribute isn't required, we are introducing an optional parameter, `countDevices`, to the method. This allows the slow query to be executed only when necessary.
heiytor
force-pushed
the
fix/namespaceGet-slow-query
branch
from
8d28c37
to
5c0e87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
NamespaceGetmethod calculates the total number of devices in a namespace, which may result in a slow query. Since this method is utilized in numerous contexts where theNamespace.DevicesCountattribute isn't required, we are introducing an optional parameter,countDevices, to the method. This allows the slow query to be executed only when necessary.