New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script: Added support for Mac user for using docker compose script #409
script: Added support for Mac user for using docker compose script #409
Conversation
Added support for Mac user for useing the command ./bin/docker-compose up -d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding! Thanks for looking at this!
I made two minor comments on the code. Please take a look.
Also, please add at the end of the commit log:
Fixes: #407
So the issue is closed when we merge this.
Some prechecks at the beginning of the script are added In the case statement if the OS is unknown (e.g. default case) then the script errors out The if statements for setting the working directory are made easier to read A couple of comments are written into the file to make it hopefully easier to understand for someone Fixes: #407
@otavio Thank you for your feedback! In the check summary I see, that one check failed due to an exceeding line length of 80 characters. Could you please point me in the right direction where I have to change something and how. Thank you 😄 |
updated Error Message for the pre checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the proposal I did. Please do whatever improvements you think are need.
Also, please squash the commits so we can merge it.
@otavio sorry for asking this again, but I don't get why the "Commit Message Check" is failing. My last commit message has just 19 characters... |
Yes; this was failing due to the pull request. I made a change to fix it so please rebase your patches and do a force push. Also, the commits ought to be squashed into a single one. Please look at it as well, when rebasing. |
This commit replaces PR #409
Fixed by #464; closing this now. |
What was the problem
This pull request originated from my opened issue #407 .
As a Mac user I couldn't use the provided script
./bin/docker-compose up -d
because on Darwin (Mac) the commandreadlink
is not supportedSummary about the code changes
I added support for Mac user for useing the command ./bin/docker-compose up -d
This is done via:
I tested the new script on my Mac and docker-compose started as expected.