Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: returns errors from mongo error definitions #943

Merged
merged 1 commit into from May 24, 2021
Merged

api: returns errors from mongo error definitions #943

merged 1 commit into from May 24, 2021

Conversation

eduardoveiga
Copy link
Contributor

  • returns ErrNoDocuments if findOne returns nothing
  • utilize Mongo-go-Driver errors definitions instead check error string
  • don't ignore any error

@eduardoveiga eduardoveiga force-pushed the topic/refactor_errors branch 2 times, most recently from caefbae to 8009e53 Compare May 14, 2021 20:47
otavio
otavio requested changes May 14, 2021
View reviewed changes
api/store/mongo/device_store.go Outdated Show resolved Hide resolved
@eduardoveiga eduardoveiga force-pushed the topic/refactor_errors branch 5 times, most recently from 1496d92 to 305f617 Compare May 17, 2021 17:53
otavio
otavio reviewed May 17, 2021
View reviewed changes
api/store/mongo/utils.go Outdated Show resolved Hide resolved
@eduardoveiga eduardoveiga force-pushed the topic/refactor_errors branch 2 times, most recently from 0fa2b41 to 24591cc Compare May 17, 2021 19:05
@eduardoveiga eduardoveiga requested a review from otavio May 17, 2021 19:13
otavio
otavio requested changes May 17, 2021
View reviewed changes
api/store/mongo/device_store.go Outdated Show resolved Hide resolved
api/store/mongo/device_store.go Outdated Show resolved Hide resolved
api/store/mongo/firewall_store.go Show resolved Hide resolved
api/store/mongo/namespace_store.go Outdated Show resolved Hide resolved
api/store/mongo/user_store.go Show resolved Hide resolved
api/store/mongo/utils.go Outdated Show resolved Hide resolved
@eduardoveiga eduardoveiga requested a review from otavio May 17, 2021 19:49
otavio
otavio requested changes May 18, 2021
View reviewed changes
api/store/mongo/firewall_store.go Outdated Show resolved Hide resolved
api/store/mongo/user_store.go Outdated Show resolved Hide resolved
@eduardoveiga eduardoveiga requested review from otavio and gustavosbarreto and removed request for leonardojoao May 20, 2021 12:29
otavio
otavio previously approved these changes May 20, 2021
View reviewed changes
@otavio otavio added this to the 0.8.0 milestone May 22, 2021
@eduardoveiga
api: returns errors from mongo error definitions
1211647 
returns ErrNoDocuments if findOne returns nothing
utilize Mongo-go-Driver errors definitions instaed check error string
don't ignore any error
@eduardoveiga eduardoveiga requested a review from otavio May 23, 2021 20:17
@gustavosbarreto gustavosbarreto merged commit bc2f49d into master May 24, 2021
@gustavosbarreto gustavosbarreto deleted the topic/refactor_errors branch May 24, 2021 20:16
@eduardoveiga eduardoveiga restored the topic/refactor_errors branch May 25, 2021 15:05
@otavio otavio modified the milestones: 0.8.0, 0.7.2 May 26, 2021
@eduardoveiga eduardoveiga deleted the topic/refactor_errors branch May 30, 2021 14:27
@otavio otavio modified the milestones: 0.7.2, 0.8.0 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavosbarreto gustavosbarreto Awaiting requested review from gustavosbarreto

@otavio otavio Awaiting requested review from otavio

Assignees
No one assigned
Labels
area/api kind/refactor status/needs-review
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eduardoveiga @otavio @gustavosbarreto