2016-02-23 23:18 UTC+0100 Przemyslaw Czerpak (druzus/at/poczta.onet.pl)

[druzus]

• shellinabox/vt100.jspp
  ! fixed key modifiers encoding.
  They should be calculated as bitfield for
  SHIFT = 1
  ALT = 2
  CTRL = 4
  and then incremented by 1.
  ref:
  http://www.xfree86.org/4.7.0/ctlseqs.html#PC-Style%20Function%20Keys
  http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-PC-Style-Function-Keys

[KLuka]

Hello, and thank you for your patch 👍

I looked at the provided specs and it seams that your patch correctly handles modifier keys, but I am not sure how to test it (manually). Could you maybe describe manual testcase (what keys to press and what should/shouldn't happen or something like that)?

[druzus]

On Wed, 24 Feb 2016, Luka Krajger wrote: Hi,

Hello, and thank you for your patch 👍 I looked at the provided specs and it seams that your patch correctly handles modifier keys, but I am not sure how to test it (manually). Could you maybe describe manual testcase (what keys to press and what should/shouldn't happen or something like that)?

Edit and function keys pressed with CTRL, ALT or SHIFT modifiers generated wrong key sequences. Just use XTerm compatible terminal (original XTerm is quite good choice ;)) and type cat in the shell prompt. Then hit HOME, END, LEFT, RIGHT, ..., Fn... with CTRL, ALT, SHIFT modifiers. Key modifiers are encoded as part of escape sequences in decimal form. For comparison I suggest to use F5 - F10 function keys because they use the same format in most of terminal emulation modes, key modifier is encoded as 2-nd number after ;, i.e.: SHIFT + F5: ESC [ 1 5 ; 2 ~ ALT + F5: ESC [ 1 5 ; 3 ~ CTRL + F5: ESC [ 1 5 ; 5 ~ SHIFT + ALT + F5: ESC [ 1 5 ; 4 ~ CTRL + ALT + F5: ESC [ 1 5 ; 7 ~ SHIFT + ALT + CTRL + F5: ESC [ 1 5 ; 8 ~ If you repeat this test with ShellInABox then you will see that key modifiers are wrongly encoded: SHIFT + F5: ESC [ 1 5 ; 1 ~ ALT + F5: ESC [ 1 5 ; 2 ~ CTRL + F5: ESC [ 1 5 ; 4 ~ SHIFT + ALT + F5: ESC [ 1 5 ; 3 ~ CTRL + ALT + F5: ESC [ 1 5 ; 6 ~ SHIFT + ALT + CTRL + F5: ESC [ 1 5 ; 7 ~ the key modifier value should be 1 greater. In terminal window ESC in above sequences is presented as: ^[ Harbour users working with GTTRM (terminal input/output driver for Harbour compiler - https://harbour.github.io/) reported that edit and function keys with CTRL, ALT and SHIFT modifiers in ShellInABox are not recognized correctly. I've checked it and I've found above problem. BTW There are few other minor problems with it, i.e. CTRL + ENTER sends \r instead of \n or it does not reports cursor position after ESC [ 6 n this is very important functionality because it's the only one portable method to detect if terminal is in ISO or UTF8 mode. If you have nothing against then in some spare time I'll create next patches. best regards, Przemek

[KLuka]

Thanks for posting extensive information. From xterm comparison we can really see that we have a bug in this area. I guess that it present since the first release, but no one noticed it until now :)

If you have nothing against then in some spare time I'll create next patches.

Please do :) Me and other users will be very grateful. And thank you again for your work 👍