Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust scale on IE #363

Merged
merged 1 commit into from Mar 1, 2016
Merged

adjust scale on IE #363

merged 1 commit into from Mar 1, 2016

Conversation

tomtor
Copy link
Contributor

@tomtor tomtor commented Feb 25, 2016

On IE 11 the computed width (nr of columns) is too large.
I loose on average about 3 characters on the right side.

This is a quick hack to fix this.

@KLuka
Copy link
Member

KLuka commented Feb 26, 2016

Thanks for the patch 👍 I will check this out as soon as I get access to some IE11 :)

@tomtor
Copy link
Contributor Author

tomtor commented Feb 27, 2016

Note that somehow this whole computation is VERY browser specific.
Firefox width is more or less OK, Chrome is often too narrow (but that is only a cosmetic issue) and IE often too wide (loosing characters on the right is very annoying).

Most people will not notice, until you start eg "tmux" which has a status banner on the bottom of the screen.

KLuka added a commit that referenced this pull request Mar 1, 2016
adjust scale on IE

On IE 11 the computed width (nr of columns) is too large.
@KLuka KLuka merged commit ee57908 into shellinabox:master Mar 1, 2016
@KLuka
Copy link
Member

KLuka commented Mar 1, 2016

You are correct, there are a lot of differences between browsers when we are detecting terminal width. For Chrome we can even see this in gif from project README :) Maybe we can find solution that will work better for all major browsers, but for now I am pulling your patch in...

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants