free the sshPort to prevent memory leak and indent newly added code to preserve code styling #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for another patch. And thank you, @guanglinlv for noticing the leak 👍 I totally missed it :/ |
| memcpy(host, ptr , size-1); | ||
| sshPort = strdup (tmp + 1); | ||
| memcpy(host, ptr , size - 1); | ||
| sshPort = strdup (tmp + 1); |
There was a problem hiding this comment.
i think any allocation should be check. you can use the check macro. it is useful for handling the abnormal case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging. I made this new pull request to address guanglinlv's comment from pull request #370