handling symlink with '-L' option for copying #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking good! can you please add some tests for the edge cases this is supposed to cover? |
|
@sparkleholic would you be able to add tests? Sorry about the delay! |
|
@sparkleholic: Any chance you'd be able to add some tests? Thanks! |
|
@ariporad this might be another PR we should take over, unless @sparkleholic responds soon. |
|
@nfischer: Works for me. |
|
@sparkleholic Thanks for the PR! I'm afraid I'll have to close this since we opted with #232 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue & Code changes