New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(.npmignore): update npmignore #339
Conversation
@nfischer: Ready for review. |
tmp/ | ||
scripts/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nfischer: I suppose we could, but I can't think of a reason anyone who downloads it from npm would ever need them, so I thought we may as well save them the bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the only reason is so that they can run tests to verify their build works. It might be helpful for debugging someone's problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Ok.
d8ddcb2
to
fb574eb
Compare
fb574eb
to
3e22277
Compare
@nfischer: should be fixed now. |
LGTM |
chore(.npmignore): update npmignore
No description provided.