Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn that README contains newest features #410

Merged
merged 1 commit into from Apr 26, 2016
Merged

Conversation

nfischer
Copy link
Member

Might be a good idea, in light of #405 and #406

[README](https://github.com/shelljs/shelljs). To read docs that are consistent
with the latest release, check out [the npm
page](https://www.npmjs.com/package/shelljs) or
[shelljs.org](http://documentup.com/shelljs/shelljs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we don't own shelljs.org, and documentup is generated from master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shelljs.org redirects to documentup, right? And documentup is only generated when we actually generate it, which is usually once per release. Npm is pretty reliable though, and there's no way that its docs would be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I didn't know it did that. TIL.

@ariporad
Copy link
Contributor

ariporad commented Apr 6, 2016

LGTM! But could you rebase?

@nfischer
Copy link
Member Author

nfischer commented Apr 6, 2016

@ariporad If we switch to a dev branch like you suggested, it would probably cleaner to just close this. That way docs would not get updated with new features until the next release.

If we find an error with the docs (maybe something is confusing or incomplete), we can merge that into master sooner and rebase dev off of master.

@ariporad
Copy link
Contributor

ariporad commented Apr 7, 2016

SGTM

@ariporad
Copy link
Contributor

@nfischer: One problem with this is that we would push the notice to npm, which wouldn't make much sense.

@nfischer
Copy link
Member Author

@ariporad What do you mean by the latest notice? Not quite following you.

@ariporad
Copy link
Contributor

If we add a notice that the README is the dev version, then when we push
the README to npm, the notice will be included. Which doesn't make much
sense.

Ari

On Mon, Apr 25, 2016 at 5:17 PM, Nate Fischer notifications@github.com
wrote:

@ariporad https://github.com/ariporad What do you mean by the latest
notice? Not quite following you.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#410 (comment)

@nfischer
Copy link
Member Author

I see your point. This notice isn't intended to say so much as "these docs are out of date, don't trust them," but more as "regardless of whether you're at Github or npm, the latest features are at Github and the most-recent-release docs are at npm." If there's a way to better phrase that, let's do it.

@ariporad
Copy link
Contributor

KK. LGTM!

@ariporad ariporad merged commit 19df52d into master Apr 26, 2016
@ariporad ariporad deleted the docs-readme branch April 26, 2016 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants