New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: warn that README contains newest features #410
Conversation
[README](https://github.com/shelljs/shelljs). To read docs that are consistent | ||
with the latest release, check out [the npm | ||
page](https://www.npmjs.com/package/shelljs) or | ||
[shelljs.org](http://documentup.com/shelljs/shelljs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we don't own shelljs.org, and documentup is generated from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shelljs.org redirects to documentup, right? And documentup is only generated when we actually generate it, which is usually once per release. Npm is pretty reliable though, and there's no way that its docs would be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I didn't know it did that. TIL.
LGTM! But could you rebase? |
@ariporad If we switch to a If we find an error with the docs (maybe something is confusing or incomplete), we can merge that into |
SGTM |
@nfischer: One problem with this is that we would push the notice to npm, which wouldn't make much sense. |
@ariporad What do you mean by the latest notice? Not quite following you. |
If we add a notice that the README is the dev version, then when we push Ari On Mon, Apr 25, 2016 at 5:17 PM, Nate Fischer notifications@github.com
|
I see your point. This notice isn't intended to say so much as "these docs are out of date, don't trust them," but more as "regardless of whether you're at Github or npm, the latest features are at Github and the most-recent-release docs are at npm." If there's a way to better phrase that, let's do it. |
KK. LGTM! |
Might be a good idea, in light of #405 and #406