Replace the "node" shell command in shell.js with process.execPath #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms like Ubuntu/Debian where the node command has been taken by a throwback command (node(8) - Node front end for AX.25, NET/ROM, Rose and TCP), the shell js exec goes into an infinite loop because the node command exits with status 1.
I ran into this error while figuring out how to build pdf.js
mozilla/pdf.js#2608
I use process.execPath to invoke the node command again, so that it picks up and runs the sub command with "/usr/bin/nodejs" instead of "node".
This had to be quoted again for the shell, to accommodate win32 versions as well which need to run "C:\Program Files" which has a space in it.