Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(touch): add coverage for -d option #925

Merged
merged 1 commit into from Jan 4, 2019
Merged

test(touch): add coverage for -d option #925

merged 1 commit into from Jan 4, 2019

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Jan 4, 2019

No change to production logic.

We never had coverage for touch({'-d': ...}), so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the Date type.

Test: handles date argument case

No change to production logic.

We never had coverage for `touch({'-d': ...})`, so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the `Date` type.

Test: `handles date argument` case
@nfischer nfischer force-pushed the test-touch-date branch from df7de8d to e1fb25a Jan 4, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 4, 2019

Codecov Report

Merging #925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          34       34           
  Lines        1281     1281           
=======================================
  Hits         1246     1246           
  Misses         35       35
Impacted Files Coverage Δ
src/touch.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355287e...e1fb25a. Read the comment docs.

@nfischer
Copy link
Member Author

@nfischer nfischer commented Jan 4, 2019

This was covered by some cp.js tests, but it's probably clearer to put a test in touch.js anyway.

@nfischer nfischer merged commit 5371e16 into master Jan 4, 2019
4 checks passed
@nfischer nfischer deleted the test-touch-date branch Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants