Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-preview): add key prop to select.item component #124

Merged
merged 2 commits into from Jan 6, 2024

Conversation

Aboubakary833
Copy link
Contributor

@Aboubakary833 Aboubakary833 commented Jan 6, 2024

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • [] yes (breaking changes will not be merged unless absolutely necessary)
  • no

Fixes #123

Description

Added missing key to Select.Item component in mobile.jsx file.

Copy link
Collaborator

@lordelogos lordelogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@lordelogos lordelogos changed the title fix(preview): Add key prop to Select.Item component fix(preview): add key prop to select.item component Jan 6, 2024
@shellscape
Copy link
Owner

@lordelogos tests didn't run bc of a lint error

@lordelogos
Copy link
Collaborator

lordelogos commented Jan 6, 2024

@lordelogos tests didn't run bc of a lint error

Fixed! @shellscape

Copy link
Owner

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lordelogos lordelogos merged commit 75d7595 into shellscape:main Jan 6, 2024
4 checks passed
shellscape pushed a commit that referenced this pull request Jan 6, 2024
Co-authored-by: lordelogos <paulehiks@gmail.com>
@shellscape shellscape changed the title fix(preview): add key prop to select.item component fix(app-preview): add key prop to select.item component Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key prop is missing on Select.Item component
3 participants