Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-preview): support for nested directories in sidebar #146

Merged
merged 19 commits into from Jan 22, 2024

Conversation

ryanlanciaux
Copy link
Collaborator

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Resolves #53

Description

The intent of this PR is to allow nested templates. Templates in the root directory should still work as they do today. Sibling folders that contain templates should show up in the sidebar as a folder with templates under them.

image

@shellscape shellscape changed the title feat(app-preview): Add nested sidebar feat(app-preview): support for nested directories in sidebar Jan 22, 2024
@shellscape
Copy link
Owner

We're getting ready to merge this one. Here's a video of what it's looking like:
https://github.com/shellscape/jsx-email/assets/76371/08fc5b64-d1f3-4381-b7f5-e440cd7fdcab

@shellscape shellscape merged commit 7d0c915 into shellscape:main Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to use preview with a nested template structure
2 participants