fix(app-preview): Change how root path is determined for singular template - #150
Merged
Conversation
|
There should not be differences in path resolution from single or multiple templates |
# Conflicts: # packages/jsx-email/src/cli/commands/preview.ts
shellscape
force-pushed
the
fix/path-one-template
branch
20 times, most recently
from
January 23, 2024 22:17
10c97c5 to
fadf0be
Compare
shellscape
force-pushed
the
fix/path-one-template
branch
from
January 23, 2024 22:17
fadf0be to
95cd534
Compare
Owner
|
@sysmat that was changed up. not to worry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
There is an issue when there is only one template present and how the path for the sidebar is handled. This should resolve that issue but selecting the root path in a different way for singular templates.