feat(create-jsx-email): setup npx command #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into branch
shellscape
reviewed
Oct 8, 2023
shellscape
reviewed
Oct 8, 2023
shellscape
reviewed
Oct 8, 2023
shellscape
reviewed
Oct 8, 2023
Comment on lines
12
to
14
| "@jsx-email/all": "2.0.0", | ||
| "@jsx-email/cli": "1.0.9", | ||
| "superstruct": "1.0.3" |
There was a problem hiding this comment.
we'll want to use "^ ranges on these dependencies, same with react below. otherwise we'll be on the hook for updating this for every patch release.
shellscape
reviewed
Oct 8, 2023
shellscape
reviewed
Oct 8, 2023
shellscape
reviewed
Oct 8, 2023
packages/create-jsx-email/starter/templates/starter-template.tsx
Outdated
Show resolved
Hide resolved
shellscape
force-pushed
the
feat/email-setup
branch
from
4421af0
to
12fdb92
Compare
shellscape
force-pushed
the
feat/email-setup
branch
from
12fdb92
to
33eae5f
Compare
|
LGTM🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
create-jsx-email
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This PR sets up the
create-jsx-emailcommand. The fastest way to setup ajsx-emailprojectUsage