Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): use alias for preview, support host flag, mute false positive warnings #37

Merged
merged 6 commits into from Oct 15, 2023

Conversation

shellscape
Copy link
Owner

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This PR makes a few changes:

  1. Ditches using symlinks for the Preview templates and shifts to using resolve.alias https://vitejs.dev/config/shared-options.html#resolve-alias. This also resolves the issue when the preview was started in the same directory as node_modules that contains the CLI
  2. Cleans up the email template for the create command
  3. Mutes the false-positive sourcemap warnings when starting the preview

@shellscape
Copy link
Owner Author

@lordelogos I'm going to publish a test version of these changes before we merge it. Lots of updates, finally figured out how to leverage Vite's dynamic imports correctly. The preview should be much faster to load and display.

@shellscape shellscape changed the title fix(cli): use alias instead of symlink for preview, mute warnings feat(cli): use alias for preview, support host flag, mute false positive warnings Oct 15, 2023
@shellscape shellscape merged commit a23c30a into main Oct 15, 2023
4 checks passed
@shellscape shellscape deleted the fix/cli/use-alias-mute-warn branch October 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants