New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): use tsup (again) to produce compatible esm and cjs builds #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
force-pushed
the
chore/repo/esm-build-again
branch
16 times, most recently
from
October 21, 2023 05:04
42ecaa4
to
f4ef43f
Compare
shellscape
force-pushed
the
chore/repo/esm-build-again
branch
from
October 21, 2023 05:05
f4ef43f
to
fb9704d
Compare
shellscape
force-pushed
the
chore/repo/esm-build-again
branch
8 times, most recently
from
October 23, 2023 01:58
29758d1
to
6540242
Compare
…tensions can't handle them
shellscape
force-pushed
the
chore/repo/esm-build-again
branch
from
October 23, 2023 01:59
6540242
to
f46e779
Compare
shellscape
changed the title
fix(*): use tsup (again) to produce compatible esm and cjs builds
chore(repo): use tsup (again) to produce compatible esm and cjs builds
Oct 23, 2023
The interdependency between |
# Conflicts: # packages/all/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Fixes #38
Description
This PR (re)introduces
tsup
for building packages. We're taking a page out of tanstack's book for how they're usingtsup
. Used https://stackblitz.com/edit/stackblitz-starters-jkyxrt?file=package.json,index.js to test this with a test release of the font component, and tested manually, locally. Shouldn't result in any disruptions for anyone using the packages already.