Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): use tsup (again) to produce compatible esm and cjs builds #42

Merged
merged 15 commits into from Oct 23, 2023

Conversation

shellscape
Copy link
Owner

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Fixes #38

Description

This PR (re)introduces tsup for building packages. We're taking a page out of tanstack's book for how they're using tsup. Used https://stackblitz.com/edit/stackblitz-starters-jkyxrt?file=package.json,index.js to test this with a test release of the font component, and tested manually, locally. Shouldn't result in any disruptions for anyone using the packages already.

@shellscape shellscape force-pushed the chore/repo/esm-build-again branch 16 times, most recently from 42ecaa4 to f4ef43f Compare October 21, 2023 05:04
@shellscape shellscape force-pushed the chore/repo/esm-build-again branch 8 times, most recently from 29758d1 to 6540242 Compare October 23, 2023 01:58
@shellscape shellscape changed the title fix(*): use tsup (again) to produce compatible esm and cjs builds chore(repo): use tsup (again) to produce compatible esm and cjs builds Oct 23, 2023
@shellscape
Copy link
Owner Author

The interdependency between all in the templates that render is using in tests is forcing us to publish these updates manually, locally rather than using CI.

# Conflicts:
#	packages/all/package.json
@shellscape shellscape merged commit 35163e7 into main Oct 23, 2023
2 checks passed
@shellscape shellscape deleted the chore/repo/esm-build-again branch October 23, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM build is not working
2 participants