fix(all,cli,render,tailwind): use rehype, remove cheerio and terser #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
force-pushed
the
fix/render/use-rehype
branch
3 times, most recently
from
22e1e02
to
a45882c
Compare
shellscape
changed the title
shellscape
force-pushed
the
fix/render/use-rehype
branch
from
a45882c
to
a7e22e2
Compare
shellscape
force-pushed
the
fix/render/use-rehype
branch
from
a7e22e2
to
b4b9a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component / Package Name:
This PR contains:
Are tests included?
Breaking Changes?
If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
While technically the differences in output could constitute a breaking change, nothing in the API layer of the project has changed.
Retesting output from jsx-email is not a recommended practice. Howeer, If you were re-testing output from jsx-email, you'll want to update those tests.
This PR swaps out
cheerioandhtml-minifier-terserforrehypeand comparable plugins.cheerioandhtml-minifier-terserare very good and very fast, and that's why we initially went with them. However, they give Vite a lot of trouble while running the dev server, and so the decision was made to move to something else. Rehype does a fine job, and while the minification output is ever so slightly larger, it's much faster at both manipulating the HTML (whichcheeriowas doing for us) and minifying.