Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single comment with quote #154

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

life777
Copy link
Contributor

@life777 life777 commented Dec 2, 2020

**Which issue #145 if any, does this resolve?

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Adds new API
  • Extends existing API, backwards-compatible
  • Introduces a breaking change
  • Fixes a bug

This fix is simple. Before when code finds a quote symbol in comment it overwrites an this.input and this.tokenizer before new token for the comment is created. It means when code tries to get a position by offset getPosition it searches for in in new input, but should in old one.

@codecov-io
Copy link

Codecov Report

Merging #154 (ebd3129) into master (d19dff9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files           3        3           
  Lines         153      153           
=======================================
  Hits          149      149           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19dff9...ebd3129. Read the comment docs.

@shellscape
Copy link
Owner

Thanks for opening a PR for this 🍺 I'll have a look early tomorrow.

@life777
Copy link
Contributor Author

life777 commented Dec 11, 2020

@shellscape
Are there any problems with my fix that I should change?

@shellscape shellscape merged commit 0cacd37 into shellscape:master Feb 22, 2021
@shellscape
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants