Skip to content

Commit

Permalink
chore: rem peerDep change now that we're using pnpm, reapply peerDep fix
Browse files Browse the repository at this point in the history
  • Loading branch information
shellscape committed Jul 28, 2021
1 parent 5ff6832 commit 830a1b2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"lint:docs": "prettier --write README.md",
"lint:js": "eslint --cache --fix --cache scripts src test",
"lint:json": "prettier --write codecov.yml package.json",
"posttest": "pnpm switch -- \"4\"",
"posttest": "pnpm switch -- \"4\" && pnpm install",
"prepublishOnly": "pnpm lint && pnpm build",
"pretest": "pnpm build",
"security": "pnpm audit --audit-level=high --prod",
Expand All @@ -36,7 +36,7 @@
"LICENSE"
],
"peerDependencies": {
"webpack": "^4.44.2"
"webpack": "^4.44.2 || ^5.47.0"

This comment has been minimized.

Copy link
@jorrit

jorrit Jul 29, 2021

Contributor

Was this change intentional? It breaks NPM again.

This comment has been minimized.

Copy link
@shellscape

shellscape Jul 29, 2021

Author Owner

how do you figure?

This comment has been minimized.

Copy link
@jorrit

jorrit Jul 29, 2021

Contributor

Sorry, misread it completely! My apologies.

},
"dependencies": {
"tapable": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/set-webpack-version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if (!version) {

const versions = (pkg['webpack-versions'] as Versions)[version];

pkg.peerDependencies.webpack = versions.webpack;
// pkg.peerDependencies.webpack = versions.webpack;

Object.keys(versions).forEach((key) => ((pkg.devDependencies as Deps)[key] = versions[key]));

Expand Down

0 comments on commit 830a1b2

Please sign in to comment.