feat: add filter, map, reduce options #66
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 100% 98.59% -1.41%
==========================================
Files 2 2
Lines 56 71 +15
==========================================
+ Hits 56 70 +14
- Misses 0 1 +1
Continue to review full report at Codecov.
|
mastilver
force-pushed
the
add-filter-options
branch
2 times, most recently
from
9cf27b2
to
0b413f8
Compare
spec/plugin.spec.js
Outdated
| }, { | ||
| manifestOptions: { | ||
| filter: function(entry) { | ||
| return entry.isInitial; |
There was a problem hiding this comment.
@a-x- Does that looks good to you?
mastilver
force-pushed
the
add-filter-options
branch
from
0b413f8
to
d7b759c
Compare
mastilver
changed the title
mastilver
force-pushed
the
add-filter-options
branch
from
c67c494
to
9f743c4
Compare
README.md
Outdated
|
|
||
| Type: `function` | ||
|
|
||
| Filter out files. |
There was a problem hiding this comment.
I think will be cool to add examples here and below:
e.g.
// #48 Include initial chunks only (w/o dynamic dependencies)
filter: ({chunk, file}) => {
return chunk.isInitial();
}There was a problem hiding this comment.
I don't know, I don't really want to pollute the readme too much...
spec/plugin.spec.js
Outdated
| manifestOptions: { | ||
| reduce: function (manifest, file) { | ||
| manifest[file.name] = { | ||
| file:file.path, |
There was a problem hiding this comment.
We definitely need to setup eslint as some point
I personally have a preference for https://github.com/sindresorhus/xo , but really I don't mind ;)
README.md
Outdated
|
|
||
| Type: `function` | ||
|
|
||
| Create the manifest. It must return an `Object`. The default one will take the name of the chunk as a key and the path of the file as the value. |
There was a problem hiding this comment.
As I understand, we should note here: «custom reduce opt function replaces that default reduce logic:
function (manifest, file) {
manifest[file.name] = file.path;
return manifest;
}
lib/plugin.js
Outdated
| manifest = files.reduce(function (manifest, file) { | ||
| manifest[file.name] = file.path; | ||
| return manifest; | ||
| }, {}); |
There was a problem hiding this comment.
use seed instead of {}
closes #46
closes #55
closes #35