Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate publicPath in flavour of webpack's #80

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

mastilver
Copy link
Contributor

BREAKING CHANGE: deprecate webpack-manifest-plugin's publicPath options in flavour of webpack's output.publicPAth

closes #65

BREAKING CHANGE: deprecate webpack-manifest-plugin's publicPath options in flavour of webpack's output.publicPAth
@mastilver mastilver added this to the v2.x milestone Sep 8, 2017
@codecov-io
Copy link

codecov-io commented Sep 8, 2017

Codecov Report

Merging #80 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   98.57%   98.59%   +0.02%     
==========================================
  Files           2        2              
  Lines          70       71       +1     
==========================================
+ Hits           69       70       +1     
  Misses          1        1
Impacted Files Coverage Δ
lib/plugin.js 98.57% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de15a87...977214f. Read the comment docs.

@mastilver mastilver merged commit 4cca186 into master Sep 10, 2017
@mastilver mastilver deleted the deprecate-public-path branch September 10, 2017 09:35
@rossta
Copy link

rossta commented Sep 18, 2017

@mastilver Plans to release this feature soon?

@mastilver
Copy link
Contributor Author

mastilver commented Sep 18, 2017

Hi @rossta

release plan:
v2.0.0.rc-1 by the end of the week
v2.0.0 next week

@rossta
Copy link

rossta commented Sep 18, 2017

@mastilver Thanks for the response and the all the hard work on the project!

@s00d
Copy link

s00d commented Mar 13, 2018

thank you for breaking everything :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate publicPath
4 participants