Before/After hooks should not consume stdin data

shellspec · Jun 19, 2020 · f1dccd3 · f1dccd3
1 parent db1c1f2
commit f1dccd3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/core/hook.sh b/lib/core/hook.sh
@@ -38,7 +38,7 @@ shellspec_call_hook() {
       ;;
   esac
 
-  eval "SHELLSPEC_HOOK=\$2 && $2 &&:" &&:
+  { eval "SHELLSPEC_HOOK=\$2 && $2 &&:" &&:; } < /dev/null
   SHELLSPEC_HOOK_STATUS=$?
   return $SHELLSPEC_HOOK_STATUS
 }

diff --git a/spec/core/hook_spec.sh b/spec/core/hook_spec.sh
@@ -111,6 +111,22 @@ Describe "core/hook.sh"
     End
   End
 
+  Describe 'shellspec_call_hook()'
+    example_hooks() {
+      shellspec_register_before_hook EXAMPLE cat
+    }
+
+    Data
+      #|dummy data
+    End
+
+    It 'does not consume stdin data.'
+      BeforeCall example_hooks
+      When call shellspec_call_before_hooks EXAMPLE
+      The stdout should be blank
+    End
+  End
+
   Describe 'shellspec_mark_group()'
     Before "shellspec_mark_group 12345"