Added note listing page UI #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yedhink
reviewed
Sep 13, 2022
There was a problem hiding this comment.
@sheminanto I have added some comments. I haven't pinpointed all spots within this PR where a similar change ought to be made. It's your responsibility during self-review to figure where all similar changes ought to be made.
You can:
- Either raise a new PR making the changes i've requested here
- Or make these requested changes along with the next PR you were planning to make and mention in the comment that you have fixed these changes too.
PS: You can merge all PRs on your own without having to wait for my review. I will review async.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
