Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Close after clicking on selected option #230

Closed
azamat-sharapov opened this issue Jan 26, 2017 · 2 comments
Closed

Question: Close after clicking on selected option #230

azamat-sharapov opened this issue Jan 26, 2017 · 2 comments

Comments

@azamat-sharapov
Copy link

Using version 1.1.4.

When certain option is selected, and :allow-empty='false', clicking on already-selected option does nothing. I would like to close dropdown instead. Is it possible without hacking core? If not, will you accept PR for this?

Thanks!
@shentao
Copy link
Owner

shentao commented Jan 26, 2017

Sounds good. Would gladly accept a PR with this functionality! :D

@azamat-sharapov
Copy link
Author

Should we introduce new prop for this (like close-on-selected-click or whatever you may suggest) or just closing on :allow-empty='false' is fine?

azamat-sharapov added a commit to azamat-sharapov/vue-multiselect that referenced this issue Jan 28, 2017
@azamat-sharapov
Close when clicked on selected option. Close shentao#230
881c509
@azamat-sharapov azamat-sharapov mentioned this issue Jan 28, 2017
Closed
@shentao shentao closed this as completed in 32c558b Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azamat-sharapov @shentao