Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1499): Add Typescript defs for public methods #1609

Conversation

mattelen
Copy link
Collaborator

@mattelen mattelen commented Nov 4, 2022

Adds Typescripts defs for public methods. Fixes #1499.

@mattelen mattelen linked an issue Nov 4, 2022 that may be closed by this pull request
@mattelen
Copy link
Collaborator Author

mattelen commented Nov 4, 2022

@akki-jat could I get you to double check this will work. I'm a bit green with TS, but I noticed you built the original definitions. Thanks

@mattelen mattelen self-assigned this Nov 4, 2022
Copy link
Collaborator

@akki-jat akki-jat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattelen mattelen merged commit 1ff7dd3 into master Nov 4, 2022
@mattelen mattelen deleted the 1499-programmatic-control-methods-are-missing-in-typescript-declaration branch November 4, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatic control methods are missing in typescript declaration
2 participants