-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.0 Docs #1740
Version 3.0 Docs #1740
Conversation
@akki-jat when you have a moment, I would appreciate a look over the documentation, and make sure I haven't missed anything in terms of general vue 2 -> vue 3 changes, or any other mistakes I may have made. Feel free to look at the code, but as I've mentioned earlier, it isn't that great, but keen to get this out. I'll fix up the circleci issues in the meantime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattelen Checked locally, looks good to me. Good work.
This commit updates the CircleCI configuration file to use a newer version of the Node.js image (cimg/node:14.18.1) and updates the minimum required versions of Node.js and npm in the package.json file to 14.18.1 and 6.14.15 respectively.
@mattelen I have fixed CircleCI issue with 1c8592a. I think we can go ahead with this. |
I've migrated the docs from the old vue cli to the vite based Vue 3 app. I've also removed the pug language aspect of the docs.
This was a larger task than I thought it would be, and as a result, some of the approaches I've taken I now regret. Biggest one is how the example blurb and example code are in separate folders, and a bit confusing.
In the future, I'd love to migrate the docs to a VitePress setup. I thought it would be to much to do as part of this, but it's taken me so long to get this point, maybe I should have just done it - but thats ok, something for next time.
I've also swapped out the previous code view tool to Shiki, as its what VitePress and Vue use.
In terms of a code review, there is a lot here. If you want to priorities, I would like a test of the docs in the browser - make sure examples work, but also that the example and the docs are actually correct. I've tried to catch all the this.value -> this.modelValue etc, but there might be one that I've missed.
To run the docs, please run
npm run dev