Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User Experience with tab navigation #430

Merged
merged 1 commit into from Sep 27, 2017
Merged

Fix User Experience with tab navigation #430

merged 1 commit into from Sep 27, 2017

Conversation

pczarn
Copy link
Contributor

@pczarn pczarn commented Jul 13, 2017

  • Pressing Tab may no longer trigger selection of the highlighted item, unless the user actively highlighted that item

Fixes #424

@codecov-io
Copy link

codecov-io commented Jul 13, 2017

Codecov Report

Merging #430 into 2.0 will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.0     #430      +/-   ##
==========================================
+ Coverage   94.51%   94.67%   +0.16%     
==========================================
  Files           4        4              
  Lines         164      169       +5     
  Branches        9        9              
==========================================
+ Hits          155      160       +5     
  Misses          6        6              
  Partials        3        3
Impacted Files Coverage Δ
src/multiselectMixin.js 96.63% <100%> (+0.02%) ⬆️
src/pointerMixin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb7c28...f21f8c8. Read the comment docs.

@shentao shentao merged commit d430596 into 2.0 Sep 27, 2017
@shentao
Copy link
Owner

shentao commented Sep 27, 2017

Finally merged! Thanks @pczarn!

@pczarn
Copy link
Contributor Author

pczarn commented Sep 27, 2017

Yeah!!! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants