finding withdrawal #590
Merged
finding withdrawal #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bounty #590 +/- ##
=========================================
Coverage ? 41.17%
=========================================
Files ? 146
Lines ? 13247
Branches ? 0
=========================================
Hits ? 5454
Misses ? 7284
Partials ? 509 |
kevin-yuhh
reviewed
Jan 30, 2023
| ctx.EventManager().EmitEvents(sdk.Events{ | ||
| sdk.NewEvent( | ||
| types.EventTypeWithdrawalFinding, | ||
| sdk.NewAttribute(types.AttributeKeyFindingID, strconv.FormatUint(msg.FindingId, 10)), |
There was a problem hiding this comment.
Would it be better to add a programId event attribute?
There was a problem hiding this comment.
yes it should be better
yoongbok-lee
requested changes
Jan 30, 2023
proto/shentu/bounty/v1/tx.proto
Outdated
| message MsgHostRejectFindingResponse {} | ||
|
|
||
| message MsgWithdrawalFinding { |
There was a problem hiding this comment.
MsgCancelFinding should be better
x/bounty/client/cli/tx.go
Outdated
| @@ -34,6 +34,7 @@ func NewTxCmd() *cobra.Command { | |||
| NewSubmitFindingCmd(), | |||
| NewHostAcceptFindingCmd(), | |||
| NewHostRejectFindingCmd(), | |||
| NewWithdrawalFindingCmd(), | |||
x/bounty/keeper/finding.go
Outdated
| return k.SetPidFindingIDList(ctx, pid, fids) | ||
| } | ||
| } | ||
| return fmt.Errorf("finding id not exists") |
There was a problem hiding this comment.
doesn't exist or does not exist
x/bounty/keeper/finding.go
Outdated
| store := ctx.KVStore(k.storeKey) | ||
| store.Delete(types.GetProgramIDFindingListKey(pid)) | ||
| return nil | ||
|
|
| ctx.EventManager().EmitEvents(sdk.Events{ | ||
| sdk.NewEvent( | ||
| types.EventTypeWithdrawalFinding, | ||
| sdk.NewAttribute(types.AttributeKeyFindingID, strconv.FormatUint(msg.FindingId, 10)), |
There was a problem hiding this comment.
yes it should be better
|
|
||
| // Finding | ||
| const ( | ||
| errFindingNotExists uint32 = iota + 201 |
There was a problem hiding this comment.
probably better to merge these errors with above
x/bounty/types/msgs.go
Outdated
| TypeMsgSubmitFinding = "submit_finding" | ||
| TypeMsgAcceptFinding = "accept_finding" | ||
| TypeMsgRejectFinding = "reject_finding" | ||
| TypeMsgWithdrawalFinding = "withdrawal_finding" |
kevin-yuhh
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #553
Related: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)