Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty tests #591

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Bounty tests #591

merged 7 commits into from
Apr 18, 2023

Conversation

0311xuyang
Copy link
Contributor

Closes: #566
Related: #XXX

Description

  • Add e2e test about bounty module
  • Change query option on test from http api to grpc client

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (bounty@15c935d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             bounty     #591   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      147           
  Lines             ?    13775           
  Branches          ?        0           
=========================================
  Hits              ?     5702           
  Misses            ?     7547           
  Partials          ?      526           

Copy link
Collaborator

@yoongbok-lee yoongbok-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is more like a general integration test suite but still LGTM

@github-actions github-actions bot closed this Mar 20, 2023
@yoongbok-lee yoongbok-lee reopened this Mar 20, 2023
@yoongbok-lee yoongbok-lee added the blocked blocked by other issues or PRs label Mar 20, 2023
@0311xuyang 0311xuyang merged commit 471f6bb into bounty Apr 18, 2023
@0311xuyang 0311xuyang deleted the bounty-tests branch April 18, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocked by other issues or PRs stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants