Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the CSV hash table in Hash layer and fix some bugs. #371

Closed
wants to merge 4 commits into from
Closed

Add the CSV hash table in Hash layer and fix some bugs. #371

wants to merge 4 commits into from

Conversation

dengc367
Copy link
Collaborator

@dengc367 dengc367 commented Jun 4, 2021

remove lambda function in Layer
add the csv HashTable lookup functionality in Hash Layer

@dengc367
Copy link
Collaborator Author

dengc367 commented Jun 9, 2021

@shenweichen who can review this PR, I guess the hashtable functionality is usable for this library.

shenweichen
shenweichen requested changes Jun 12, 2021
View reviewed changes
Copy link
Owner

@shenweichen shenweichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some examples and docs about this feature.

@shenweichen
Copy link
Owner

please follow this contribution guide https://github.com/shenweichen/DeepCTR/blob/master/CONTRIBUTING.md

@dengc367
Copy link
Collaborator Author

OK. I will add some docs and examples shortly. @shenweichen

@dengc367
Copy link
Collaborator Author

dengc367 commented Jun 25, 2021 •
edited

@shenweichen I added some docs, you can check and review it.

@dengc367
Copy link
Collaborator Author

please follow this contribution guide https://github.com/shenweichen/DeepCTR/blob/master/CONTRIBUTING.md

OK. You can add me to the Collaborator. When I have spare time, I am grad to improve this project gradually.

@shenweichen
Copy link
Owner

please follow this contribution guide https://github.com/shenweichen/DeepCTR/blob/master/CONTRIBUTING.md

OK. You can add me to the Collaborator. When I have spare time, I am grad to improve this project gradually.

added

@shenweichen
Copy link
Owner

please follow our contribution guide so the continuous integration can run successfully

@dengc367 dengc367 mentioned this pull request Jun 29, 2021
Merged
@dengc367
Copy link
Collaborator Author

OK. I have created another PR #385 , and so this PR need to be closed. Thanks.

@dengc367 dengc367 closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenweichen shenweichen Awaiting requested review from shenweichen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dengc367 @shenweichen