fixup! fix incorrect dependents number

shenxianpeng · Mar 25, 2024 · 9609f0e · 9609f0e
1 parent 94bbdb4
commit 9609f0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/tests/test_main.py b/tests/test_main.py
@@ -33,4 +33,4 @@ def test_get_dependents_number(mock_requests_get, mock_sub_soup):
     url = "http://example.com"
     dependents_number = get_dependents_number(url)
 
-    assert dependents_number == 3
+    assert dependents_number == 0
diff --git a/used_by/main.py b/used_by/main.py
@@ -60,18 +60,20 @@ def get_dependents_number(url: str) -> int:
     total_number = 0
     soup = get_soup(url)
     menu_items = soup.find_all("a", class_="select-menu-item")
-    print(f"menu_items = {menu_items}")
 
-    for menu_item in menu_items:
-        href = menu_item["href"]
-        sub_soup = get_soup(url=f"https://github.com{href}")
-        repo_text = sub_soup.find("a", class_="btn-link selected").get_text(strip=True)
-        repo_number = int(repo_text.split()[0])
-        total_number += repo_number
-    else:
+    if not menu_items:  # if menu_items is empty
         repo_text = soup.find("a", class_="btn-link selected").get_text(strip=True)
         repo_number = int(repo_text.split()[0])
         total_number += repo_number
+    else:
+        for menu_item in menu_items:
+            href = menu_item["href"]
+            sub_soup = get_soup(url=f"https://github.com{href}")
+            repo_text = sub_soup.find("a", class_="btn-link selected").get_text(
+                strip=True
+            )
+            repo_number = int(repo_text.split()[0])
+            total_number += repo_number
 
     return total_number