Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build when deb/* changes #97

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Build when deb/* changes #97

wants to merge 7 commits into from

Conversation

schklom
Copy link

@schklom schklom commented Feb 24, 2024

The build calls to Protonmail's repo and builds from it. When that repo changes (i.e. when deb/* changes), the image should be built again.

Currently, that repo changed a few days ago, and the "build" image has not updated in a year. I don't see a reason to never update the image when the upstream repo updates frequently.

The build calls to Protonmail's repo and builds from it. When that repo changes (i.e. when deb/* changes), the image should be built again.

Currently, that repo changed a few days ago, and the "build" image has not updated in a year. I don't see a reason to never update the image when the upstream repo updates frequently.
@ShayBox
Copy link

ShayBox commented Mar 9, 2024

I think the build from source workflow has been broken since v3 released and hasn't been fixed, all the actions errored.

@schklom
Copy link
Author

schklom commented Mar 22, 2024

@ShayBox @shenxn This patch compiles and produces the images at https://hub.docker.com/r/schklom/protonmail-bridge/tags

Note that I do not do the image scan (to avoid issues), i.e. I remove

- name: Build image without push to registry
uses: docker/build-push-action@v2
with:
context: ./build
file: ./build/Dockerfile
platforms: ${{ env.PLATFORMS }}
push: true
tags: localhost:5000/protonmail-bridge:latest
- name: Scan image
id: scan
uses: anchore/scan-action@v2
with:
image: localhost:5000/protonmail-bridge:latest
fail-build: true
severity-cutoff: critical
acs-report-enable: true
- name: Upload Anchore scan SARIF report
uses: github/codeql-action/upload-sarif@v1
with:
sarif_file: ${{ steps.scan.outputs.sarif }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants