Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch between documentation and actual implementation for classes property #2588

Open
davidperezvw opened this issue Feb 2, 2024 · 1 comment

Comments

@davidperezvw
Copy link

As the documentation says (Step > Option > Classes), the classes defined in that property should be applied to the step's content element ("A string of extra classes to add to the step's content element.") but instead they are being applied in the shepherd-element shepherd-element.svelte.

Appart from that, it will be useful to seize this opportunity to review the model in order to provide more granular access to the classes setters for each of the elements (at least, for the title, text and buttons).

@chuckcarpenter
Copy link
Member

Thank you for this feedback, we're working to do some non breaking changes to help make those clearer and this is good feedback on what elements we expose for styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants