Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to also escape quotes #125

Merged
merged 1 commit into from Sep 18, 2019
Merged

Make sure to also escape quotes #125

merged 1 commit into from Sep 18, 2019

Conversation

timse
Copy link
Contributor

@timse timse commented Sep 18, 2019

Imagine a case where a stringified json is inlined as a data attribute, in this case the " must be escaped, too, in order to maintain valid html

@timse
Make sure to also escape quotes
1cbea0f 
Imagine a case where a stringified json is inlined as a data attribute, in this case the " must be escaped, too, in order to maintain valid html
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.602% when pulling 1cbea0f on timse:patch-1 into 47d5a98 on shepherdwind:master.

@shepherdwind shepherdwind merged commit d963219 into shepherdwind:master Sep 18, 2019
@timse
Copy link
Contributor Author

timse commented Sep 19, 2019

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timse @coveralls @shepherdwind @rudnitskih