Allow optional space after : in map passed as parameter to macro #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, thanks your commit. I will publish an new bugfix version soon. |
shepherdwind
added a commit
that referenced
this pull request
Jan 7, 2015
Allow optional space after : in map passed as parameter to macro
| var vm = '#macro( d $a)#foreach($_item in $a.entrySet())$_item.key = $_item.value #end#end #d ( {"foo": $foo,"bar":$bar} )' | ||
| assert.equal(' foo = a bar = b ', render(vm, {foo: 'a', bar: 'b'})) | ||
| }) | ||
|
|
There was a problem hiding this comment.
This spec file just run on browser. But for velocity.js, there is no anything about dom, so nodejs is just the same as browser.
So, this file is no necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a map is passed to a macro then you cannot have a space after the ':' e.g.
{"foo":"bar"}
With this patch, you can have:
{"foo": "bar"}