-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positives #2
Comments
I will try to fix this as quick as possible because if it returns wrong results, then Sherlock is not a reliable :( |
I got false positives on twitter, facebook, github, soundcloud, disqus, deviantart, flipboard, scribd, gravatar, imgsrc, cash.me, behance, goodreads, vsco, newgrounds, tripadvisor, blip.fm, bandcamp, slack, flickr, wordpress and unsplash for 2/3 different usernames. |
I also have false positives on all sites, mentioned by @obskyr and three more:
|
@obskyr @anabh4569 @2toxic |
I fixed it, it should work without any false positives now. 😄 |
I'm still receiving false positives on several sites. Sherlock says account found, but when I try the link provided, I get a 404. It seems like the simple solution would be to check the status code returned in the http request. https://www.github.com/rpnix Some of these are specifically 404 responses, some are a page saying the id wasn't found and requesting you to sign up. rpn01@R5057499 sherlock [master] 0 $ python3 sherlock.py --version |
@rpural Simply checking the HTTP status code that is returned is not a fool proof solution. Not all sites return a 404 when a user profile is not found. For example, Steam IDs and Steam groups do not. You literally have to parse the HTML for a particular string when checking Steam. I have 3 years of experience building social media checkers. Check out my open-source Python checker if you have time. |
I found false negative, but I can't find where the bug lies. I checked if it was problem with user agent, but sherlock's is not banned by vk and curl request returns 200. |
I believe that all of these have been addressed as of now. The only case where we still have problems is in sites where Sherlock depends on error text, and the user ends up getting a different language. |
Closing this because the false positives mentioned in this issue has been fixed. :) |
Running the program with a username that doesn't exist on any of the supported sites, you get 16 false positives:
In other words, the logic that determines whether a profile exists or not doesn't work correctly for those sites. Having a look at the current code structure, you might need to split the sites out into their own modules to get it to work satisfactorily – you'll need some more complicated logic for some of these sites (e.g. Tumblr, to pass the Oath GDPR gate).
The text was updated successfully, but these errors were encountered: