Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stray f's that break on Linux #198

Closed
wants to merge 1 commit into from

Conversation

snehankekre
Copy link
Contributor

On first cloning the original repo an running sherlock.py I kept getting syntax errors due to the f characters present on many lines. I've removed those so that it now works without breaking.

I've also replaced all instances of "TOR" with "Tor". See: https://2019.www.torproject.org/docs/faq.html.en#WhyCalledTor

Note: even though it originally came from an acronym, Tor is not spelled "TOR". Only the first letter is capitalized. In fact, we can usually spot people who haven't read any of our website (and have instead learned everything they know about Tor from news articles) by the fact that they spell it wrong.

@hoadlck
Copy link
Contributor

hoadlck commented Apr 10, 2019

Other people are using Sherlock on Linux without any problems. The f characters that you changed are how one denotes that we are using f-strings (or format strings). This is used to properly print out the results.

I suspect that the problems you were having with f characters was that you were using the wrong version of Python. Sherlock requires Python 3.6 or higher.

@TheYahya TheYahya closed this Apr 28, 2019
@TheYahya
Copy link
Member

Tnx @snehankekre, Merged.

@hoadlck
Copy link
Contributor

hoadlck commented May 15, 2019

Why was this merged? This PR removed format strings that were required for proper operation. The main line is all whacked up.

hoadlck added a commit that referenced this pull request May 15, 2019
…s getting a syntax error from the format strings (probably from using an old version of Python). But, blindly removing the f-strings broke the actual functionality.
@hoadlck
Copy link
Contributor

hoadlck commented May 15, 2019

I backed out this PR and pushed it to main. I did not have time to do detailed testing, but the failures now seem to be the "normal" ones that happen because a site is slow to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants