Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an actual package with pyproject.toml #2036

Closed
wants to merge 1 commit into from

Conversation

mjsir911
Copy link
Contributor

@mjsir911 mjsir911 commented Mar 2, 2024

Fixes #2017

name = "sherlock"
readme = "README.md"
license = {file = "LICENSE"}
dynamic = ["dependencies", "version"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version doesnt seem to be found. Would it be better to hard code it using version = 0.14.3

$ pipx install .         
  installed package sherlock 0.0.0, installed using Python 3.11.6
  These apps are now globally available
    - sherlock
done! ✨ 🌟 ✨

@mjsir911
Copy link
Contributor Author

mjsir911 commented May 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pyproject.toml for better support
2 participants