Reduce false positives (those caused by WAFs and bot detection) #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppfeister
force-pushed
the
feature/antiwaf
branch
from
21ac927
to
d660c1a
Compare
ppfeister
changed the title
ppfeister
added a commit
to ppfeister/sherlock
that referenced
this pull request
Apr 25, 2024
Instagram has been added back to the site list using the old picuki probe. This service DOES use Cloudflare, but it will function perfectly fine until rate limited. Once rate limited, sherlock-project#2069 will suppress any false positives.
ppfeister
added a commit
to ppfeister/sherlock
that referenced
this pull request
Apr 25, 2024
Untappd is behind Cloudflare, but this doesn't seem to impact early requests. After being ratelimited, sherlock-project#2069 will suppress any possible WAF-induced false positives. Closes sherlock-project#1780
|
Again, I really appricate you putting so much work into this PR as well! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussions are taking place elsewhere about false positives and bot detection circumvention.
The Cloudflare bypass, even if implemented, will fail occasionally as Cloudflare updates their detection methods. Until the maintainer of whatever bypass mechanism is able to update their tool, Sherlock users will randomly see false positives.
In either case, this PR significantly reduces the number of false positives that appear as more and more sites switch to using WAFs that function like Cloudflare. If a known WAF block page is detected, the QueryStatus of WAF is applied rather than running the standard (and now useless) error checks. Results with the status of WAF are only displayed with
--print-alland bear a status message indicating such.The error message also indicates that a proxy (such as FlareSolverr) may help.
Paired with #2068, the number of false positives presented to the user drop significantly.
Fixes #1878 (as the use of a proxy may allow Fiverr to function as desired, and it won't display false positives otherwise)
Update: This PR now also includes a fingerprint for PerimeterX -- the "press and hold" captcha service sometimes also used by sites like Fiverr