Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjustable margins support #1

Merged
merged 5 commits into from Jun 29, 2022
Merged

Add adjustable margins support #1

merged 5 commits into from Jun 29, 2022

Conversation

shermp
Copy link
Owner

@shermp shermp commented Jun 28, 2022

I figured out how to make the ReadingFooter margins adjustable, so it is now possible to bring the clock out to the very edge of the screen if desired.

If the clock is set to the right edge of the header, bookmarks will obscure the clock..

By default, the new margin is 1/10th the size of the original margin set by Kobo. It is also possible to set a custom margin size, up to one quarter of the screen width.

Precompiled binaries are available from the Actions tab on Github for testing this PR.

@shermp
Copy link
Owner Author

shermp commented Jun 28, 2022

Based on feedback from Deobulakenyo on MR, I've decided to make the automatic margin setting value auto instead of the magic number -1. It's all just strings anyway...

@pgaskin
Copy link

pgaskin commented Jun 29, 2022

I've installed this on my Clara (footer auto right), and I love it.

@shermp
Copy link
Owner Author

shermp commented Jun 29, 2022

I've installed this on my Clara (footer auto right), and I love it.

Thanks for the feedback. I'll merge this and make another release I think.

@shermp shermp merged commit 960dad6 into main Jun 29, 2022
@shermp shermp deleted the adjustable-margins branch June 29, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants