New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should set_analysis report on the "new" filter expression? #1590
Labels
Comments
hamogu
pushed a commit
to hamogu/sherpa
that referenced
this issue
Sep 23, 2022
From a numbre of searches, it seems like the Tcl_AsyncDelete: async handler deleted by the wrong thread error "caused" by matplotlib, as it defaults to the TkAgg backend. If we switch to the Agg backend does this fix the problem? Note that we currently don't actually test the matplotlib output so there should be no prioblem in the tests.
DougBurke
added a commit
to DougBurke/sherpa
that referenced
this issue
Sep 13, 2023
This follows notice/ignore (sherpa#1562) and group_xxx (sherpa#1637) changes to report the filter for any dataset that set_analysis operates on. Unfortunately it can't easily use the code used in the previous PRs since that doesn't support the "analysis units" changing, which is the main reason for set_analysis! So the code does it manually, but it's not a lot of code.
DougBurke
added a commit
to DougBurke/sherpa
that referenced
this issue
Sep 14, 2023
This follows notice/ignore (sherpa#1562) and group_xxx (sherpa#1637) changes to report the filter for any dataset that set_analysis operates on. Unfortunately it can't easily use the code used in the previous PRs since that doesn't support the "analysis units" changing, which is the main reason for set_analysis! So the code does it manually, but it's not a lot of code.
wmclaugh
added a commit
that referenced
this issue
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once #1562 lands we have
There is an argument to be made that
set_anaysis
and thegroupXXX
commands could report new filters in the same way thatnotice
andignore
now do. Note thatgroupXXX
commands now report the filter as #1637 has landedWe have a similar issue with
set_coord
, but there it is a bit-more serious, but we recently changed things so the spatial filter gets cleared:This is only for the UI level, not the lower-level
Data
methods.The text was updated successfully, but these errors were encountered: