Change a single test to use explicit rather than implicit random state from NumPy #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this test we can easily use a random state explicitly rather than the implicit state of the legacy NumPy random API. It means we can drop the reset_seed fixture for this particular test.
DougBurke
added
area:tests
note: easy review
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 72 72
Lines 27076 27076
Branches 4029 4029
=======================================
Hits 21403 21403
Misses 5510 5510
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
hamogu
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify a single test. There is no functional change.
Details
This is clean-up code which I've pulled out of #1735. Technically it's part of the aim of that PR, but it's completely standalone, and so can get taken now.
For this test we can easily use a random state explicitly rather than the implicit state of the legacy NumPy random API. It means we can drop the reset_seed fixture for this particular test.