models: change defaults for Box1D parameters #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Box1D parameters so that - xhi now starts at 1 rather than 0 - ampl uses the same range as xlow/xhi rather than -1 to +1 >>> print(Box1D()) box1d Param Type Value Min Max Units ----- ---- ----- --- --- ----- box1d.xlow thawed 0 -3.40282e+38 3.40282e+38 box1d.xhi thawed 0 -3.40282e+38 3.40282e+38 box1d.ampl thawed 1 -1 1 to >>> print(Box1D()) box1d Param Type Value Min Max Units ----- ---- ----- --- --- ----- box1d.xlow thawed 0 -3.40282e+38 3.40282e+38 box1d.xhi thawed 1 -3.40282e+38 3.40282e+38 box1d.ampl thawed 1 -3.40282e+38 3.40282e+38 Fix sherpa#1265
DougBurke
added
type:enhancement
note: easy review
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
=======================================
Coverage 81.24% 81.24%
=======================================
Files 73 73
Lines 26452 26452
Branches 3959 3959
=======================================
Hits 21491 21491
Misses 4800 4800
Partials 161 161
Continue to review full report in Codecov by Sentry.
|
anetasie
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The xlow parameter of Box1D now defaults to 1 and the ampl parameter has a greatly-increased range (from the previous version of -1 to 1).
Details
This changes the Box1D parameters so that
The CIAO 4.15 behaviour:
The new behaviour:
Fix #1265