Setuptools not required #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
setuptoolsis not required for building Sherpa. Sherpa already provides a warning whensetuptoolsis not available, but some commands likedevelopandtest, while not directly imported by Sherpa, rely on the presence ofsetuptools. With this PR, when the package is not available, Sherpa will just prints a warning on the standard output. While this is mostly required to support CIAO builds, we do claim thatsetuptoolsis not required, and this PR ensures this is true.The PR also adds a Travis build for testing the ability to build and test Sherpa without setuptools. As Travis builds have become rather cheap and quick (even though we haven't migrated to the new system ourselves), I have also reinstated the other builds, and fixed a couple of issues in the Travis build configuration.
The changes were tested locally on Linux64 by manually removing
setuptoolsand by runningpython setup.py {develop,test,install}, testing that the commands did not choke. Plus, a new build has been added to the Travis builds, exercising aninstallwithout setuptools, which is what CIAO does.