Remove chips from the documentation #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not think we need to add a section on "removed" functionality which describes the ChIPS plotting backend here.
There is still a reference to chips in sherpa/ui/utils.py.
The previous values were ChIPS specific, so that have now been updated to be for the matplotlib backend. Technically this document can be used with any backend, but there is currently only one.
DougBurke
force-pushed
the
remove-chips
branch
from
4bcf91c
to
e3e5365
Compare
DougBurke
changed the title
dtnguyen2
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove mention of ChIPS from the documentation (both on read the docs and in the sherpa.astro.ui and sherpa.ui modules), replacing with matplotlib where appropriate.
Details
Remove mention of ChIPS from the documentation. There is no change to the code in this PR (i.e. the chips backend is still present and included in the config files).
clearwindowparameterget_data_plot_prefsroutine includes chips defaults, these should either be replacedwith matplotlib values or just removed (the latter is "technically better" but not actually
useful to the user)
There are also some minor un-related doc fixes that have come along for the ride. They could be pulled out into a separate PR but it didn't seem worth it at this time.
This is ready for review.