Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of the XSPEC interface code #859

Merged
merged 6 commits into from Aug 7, 2020

Commits on Aug 4, 2020

  1. Copy the full SHA
    cb029fb View commit details
    Browse the repository at this point in the history
  2. Refactor XSPEC module

    This reduces the amount of duplication in the XSPEC extension
    header.
    DougBurke committed Aug 4, 2020
    Copy the full SHA
    a9f177f View commit details
    Browse the repository at this point in the history
  3. Refactor XSPEC: convolution models

    Refactors the code used to create the grids for the convolution
    models. This could have been made part of the general routine,
    but the explicit lack of support for grids with gaps makes it
    easier to have a separate routine.
    DougBurke committed Aug 4, 2020
    Copy the full SHA
    96db499 View commit details
    Browse the repository at this point in the history
  4. Refactor XSPEC module

    DougBurke committed Aug 4, 2020
    Copy the full SHA
    06ab027 View commit details
    Browse the repository at this point in the history
  5. Remove un-necessary bracketing

    There should be no change due to this.
    DougBurke committed Aug 4, 2020
    Copy the full SHA
    b2bba19 View commit details
    Browse the repository at this point in the history
  6. Encode tests for tabint availability into a nested structure.

    Instead of
    
      if a and not b
        declare symbol
      endif
    
      if b
      extern "C" { declare symbol }
      endif
    
    use
    
      if a
      if b
        extern "C" {
      endif
      declare symbol
      if b
        }
      endif
      endif
    
    Not sure what's cleaner.
    DougBurke committed Aug 4, 2020
    Copy the full SHA
    2bf49ef View commit details
    Browse the repository at this point in the history