Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use listpays instead of listsendpays for the list of outgoing payments #147

Closed
cdecker opened this issue Jul 27, 2020 · 2 comments
Closed

Use listpays instead of listsendpays for the list of outgoing payments #147

cdecker opened this issue Jul 27, 2020 · 2 comments

Comments

@cdecker
Copy link

cdecker commented Jul 27, 2020

Since c-lightning will start supporting sending of multi-part payments there is no longer a direct relationship between a sendpay call (or sendonion call which also generates listsendpays entries) and the overall payment.

Instead of listsendpays spark should use listpays which aggregates over all sub-payments and reports the correct amounts and the correct status.
@cdecker
Copy link
Author

cdecker commented Jul 27, 2020

The structure of both results is rather similar btw so it shouldn't be a huge change.

@cdecker cdecker mentioned this issue Jul 27, 2020
Merged
shesek added a commit that referenced this issue Aug 6, 2020
@shesek
Use listpays to retrieve the list of outgoing payments
ee7b467 
So that multi-part payments are grouped together and not displayed
separately.

This requires an additional RPC call per completed outgoing payment,
until the timestamp field is added to `listpays` (expected in the next
c-lightning release).

This change also uses the `payment_hash` as the unique payment identifier
instead of the payment id, as payment ids are not available in `listpays`.

Resolves #147.
@shesek
Copy link
Owner

shesek commented Aug 6, 2020

Thanks for the heads up! Implemented in ee7b467.

@shesek shesek closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdecker @shesek