Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling price lookup #81

Closed
hkjn opened this issue May 18, 2019 · 1 comment
Closed

Allow disabling price lookup #81

hkjn opened this issue May 18, 2019 · 1 comment
Assignees
Labels

Comments

@hkjn
Copy link
Contributor

hkjn commented May 18, 2019

Related to #78.

It would be cool if users could set a flag like --disable-rates to tell spark-wallet to not look up fiat exchange rates at all, thus reducing dependencies on third party servers and potentially improving privacy.

@shesek
Copy link
Owner

shesek commented May 19, 2019

Implemented in 7512aa9, can be set with --no-rates.

Spark will currently show USD amounts as "n/a" if you pick USD as your display unit. Ideally, the client-side should be made aware that exchange rates is off and avoid displaying USD as an option altogether. I created a separate ticket to keep track of that at #82.

@shesek shesek closed this as completed May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants